Fixes from second PR #8 review:
Critical fixes:
- Show how to actually USE $ESCAPED_PATH in final command (not just escape it)
- Add Fish shell function syntax support (uses functions not aliases)
- Add existing alias/function replacement with user confirmation
- Reorder backup timing (after user confirms, before modifying)
Improvements:
- Example output now shows path with spaces to demonstrate escaping
- Added Fish shell syntax explanation section
- Added security considerations section
- Updated "How It Works" for both Bash/Zsh and Fish
- Clear step-by-step command generation with $ESCAPED_PATH
This ensures the shell injection vulnerability is truly fixed by showing
explicit usage of the escaped path variable in the final command generation.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fixed all critical and high-priority issues from code review:
Security fixes:
- Fix shell injection vulnerability with proper path escaping
- Add timestamped backup creation before modifying shell configs
Reliability improvements:
- Add comprehensive user input path validation
- Add iCloud sync state checking with soft warnings
- Improve shell detection to use default shell (not current session)
Cross-platform support:
- Add platform detection for iCloud features (macOS only)
- Document error handling approach
- Add helpful error messages with actionable suggestions
All changes ensure the commands work safely across Linux, macOS, and
Windows while providing better UX and preventing common user mistakes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Add new /install-claudesidian-command to create shell alias for launching vault from anywhere
- Add automatic iCloud Drive vault detection in init-bootstrap
- Add iCloud-specific search path with maxdepth 5 for nested structure
- Add fallback prompt asking about iCloud if vault not found
- Update README with launcher command documentation and usage examples
- Shell command auto-resumes existing sessions or starts new ones
This addresses user feedback about iCloud vault detection and adds convenient
shell launcher similar to obsidian-cli pattern.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
