chore: apply linting fixes to PR #8 changes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Noah Brier
2025-10-07 11:37:04 -04:00
co-authored by Claude
parent ef1ef6073e
commit eddbf61f92
2 changed files with 33 additions and 17 deletions
+26 -15
View File
@@ -74,9 +74,10 @@ Then generate a customized CLAUDE.md file tailored to their needs.
- **On macOS only:** Ask: "Is your vault stored in iCloud Drive? (yes/no)"
- If yes (macOS): "Please enter the full path to your vault (e.g.,
~/Library/Mobile Documents/iCloud~md~obsidian/Documents/YourVault)"
- If no, or on Linux/Windows: "Please enter the path to your existing vault,
or type 'skip' to start fresh"
- **Validate user-provided paths** (see "User Path Validation" section below)
- If no, or on Linux/Windows: "Please enter the path to your existing
vault, or type 'skip' to start fresh"
- **Validate user-provided paths** (see "User Path Validation" section
below)
- If no existing vault or user skips, they're starting fresh
4. **Ask Configuration Questions**
@@ -363,18 +364,23 @@ If the user's response is unclear:
### Platform Compatibility
This command is designed to work across Linux, macOS, and Windows (WSL/Git Bash), with platform-specific features:
This command is designed to work across Linux, macOS, and Windows (WSL/Git
Bash), with platform-specific features:
**All Platforms:**
- Search ~/Documents, ~/Desktop, home directory
- Standard Obsidian vault detection
- Full vault import and setup
**macOS Only:**
- iCloud Drive vault detection and import
- Obsidian's iCloud sync is macOS-only, so iCloud features are disabled on other platforms
- Obsidian's iCloud sync is macOS-only, so iCloud features are disabled on other
platforms
**Platform Detection:**
```bash
# Check platform
if [[ "$OSTYPE" == "darwin"* ]]; then
@@ -419,11 +425,14 @@ The iCloud path requires:
- Silent error handling (2>/dev/null) as many users won't have iCloud
- Platform check (macOS only)
**Error Handling Note:** Permission errors are suppressed (2>/dev/null) because they're expected when searching system directories. If no vaults are found, the script gracefully prompts the user for their vault path.
**Error Handling Note:** Permission errors are suppressed (2>/dev/null) because
they're expected when searching system directories. If no vaults are found, the
script gracefully prompts the user for their vault path.
### User Path Validation
When users manually provide a vault path, validate it thoroughly with helpful error messages:
When users manually provide a vault path, validate it thoroughly with helpful
error messages:
```bash
# User provided path
@@ -487,9 +496,11 @@ echo "✓ Valid Obsidian vault found"
```
This validation:
- Expands `~` to home directory properly
- Resolves symlinks and relative paths to absolute paths
- Checks all essential requirements (exists, is directory, has .obsidian, readable)
- Checks all essential requirements (exists, is directory, has .obsidian,
readable)
- Provides helpful, actionable error messages with suggestions
- Shows the resolved path so users understand what's being checked
- Trusts users (allows symlinks, paths outside home directory)
@@ -523,6 +534,7 @@ fi
```
This provides a soft warning that:
- Only runs on macOS for iCloud paths
- Checks for placeholder files that indicate incomplete download
- Asks for confirmation if sync issues detected
@@ -588,8 +600,8 @@ First-run marker removed
Now let me ask you a few questions to customize your setup:
🔍 **Searching for existing Obsidian vaults...** [Searches ~/Documents,
~/Desktop, home directory, and parent directories. On macOS, also searches iCloud
Drive]
~/Desktop, home directory, and parent directories. On macOS, also searches
iCloud Drive]
### Case 1: Single Vault Found
@@ -642,8 +654,7 @@ You can migrate files to the PARA folders at your own pace.
🔍 **No Obsidian vaults found in common locations.**
**On macOS:**
Is your vault stored in iCloud Drive? (yes/no)
**On macOS:** Is your vault stored in iCloud Drive? (yes/no)
User: yes
@@ -659,9 +670,9 @@ Found vault at: ~/Library/Mobile Documents/iCloud~md~obsidian/Documents/MyVault
Would you like to import this vault? (yes/skip)
**On Linux/Windows:**
Please enter the path to your existing Obsidian vault, or type 'skip' to start
fresh: (Example: ~/Documents/MyVault or /home/user/obsidian-vault)
**On Linux/Windows:** Please enter the path to your existing Obsidian vault, or
type 'skip' to start fresh: (Example: ~/Documents/MyVault or
/home/user/obsidian-vault)
User: ~/Documents/MyVault
@@ -100,14 +100,17 @@ echo "📝 Config file: $CONFIG_FILE"
```
**Key improvements:**
- Uses `$SHELL` to detect default shell (not `$ZSH_VERSION`/`$BASH_VERSION` which detect current session)
- Uses `$SHELL` to detect default shell (not `$ZSH_VERSION`/`$BASH_VERSION`
which detect current session)
- Supports command-line argument to override auto-detection
- Shows detected shell and config file for transparency
- Validates shell type and provides clear error message for unsupported shells
## Installation Steps
1. **Detect shell**: Use argument if provided, otherwise auto-detect from `$SHELL`
1. **Detect shell**: Use argument if provided, otherwise auto-detect from
`$SHELL`
2. **Get vault path**: Use `pwd` to get current directory
3. **Escape the path**: Properly escape quotes and special characters for shell
safety
@@ -154,6 +157,7 @@ echo "📝 Config file: $CONFIG_FILE"
## Handling Special Characters
The implementation properly handles paths with:
- Spaces: `/Users/noah/My Vault`
- Quotes: `/Users/noah/vault's backup`
- Special characters that need escaping
@@ -190,6 +194,7 @@ Install for specific shell (override auto-detection):
```
**When to specify shell:**
- You use multiple shells and want to install for a specific one
- Auto-detection picked the wrong shell
- You're setting up for someone else