From 3797ed32deeff82ecd4fc2ac448a8a1abcaa62c0 Mon Sep 17 00:00:00 2001
From: Noah Brier <nbrier@gmail.com>
Date: Wed, 17 Sep 2025 18:42:25 -0400
Subject: [PATCH] fix: upgrade command to prevent interactive prompts and
 auto-selection

- Replace cp/cp -f with cat > for guaranteed non-interactive file replacement
- Add explicit instruction to WAIT for user input (don't auto-select option 1)
- Clarify that cp -f still causes prompts on some systems
- Ensures upgrade process doesn't hang on file overwrites
---
 .claude/commands/upgrade.md | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/.claude/commands/upgrade.md b/.claude/commands/upgrade.md
index 022c0b8..e0c11f0 100644
--- a/.claude/commands/upgrade.md
+++ b/.claude/commands/upgrade.md
@@ -76,10 +76,13 @@ capabilities.
 
 **⚠️ CRITICAL IMPLEMENTATION REQUIREMENT:**
 
-- **NEVER blindly overwrite files with `cat > file` or `cp`**
+- **NEVER blindly overwrite files without showing diffs first**
 - **ALWAYS show diffs to the user first**
 - **ALWAYS ask for confirmation before replacing files**
 - **Skipping these steps can lose user customizations!**
+- **NEVER use `cp` or `cp -f` (both can cause prompts on protected files)**
+- **ALWAYS USE `cat source > dest` for guaranteed non-interactive replacement**
+- **WAIT for actual user input - don't automatically choose option 1**
 
 For EACH file in the checklist:
 
@@ -103,10 +106,26 @@ For EACH file in the checklist:
       3. View diff and decide
       4. Try to merge both (AI-assisted)
 
-      Choice (1/2/3/4): _
+      Choice (1/2/3/4): [WAIT FOR USER TO TYPE NUMBER AND PRESS ENTER]
       ```
 
-4.  Apply the chosen strategy
+      **IMPORTANT**: Actually WAIT for the user to type their choice!
+      Do NOT automatically select any option. The user must manually
+      type 1, 2, 3, or 4 and press Enter.
+
+4.  Apply the chosen strategy:
+    - **For option 1 (Apply update/Take upstream)**:
+      ```bash
+      # IMPORTANT: Use cat with redirection to avoid ALL prompts
+      # Do NOT use cp or cp -f as they may still prompt on some systems
+      cat .tmp/claudesidian-upgrade/path/to/file > path/to/file && echo "✅ Updated"
+      # Alternative if needed: rm -f path/to/file && cat .tmp/claudesidian-upgrade/path/to/file > path/to/file
+      ```
+    - **For option 2 (Keep your version)**:
+      ```bash
+      echo "✅ Kept your version"
+      ```
+    - **For option 4 (AI merge)**: Read both files and create merged version
 5.  **CRITICAL: Update the checklist file immediately**:
     ```markdown
     [ ] .claude/commands/init-bootstrap.md → becomes → [x]