Implement comprehensive weather parsing capabilities following Clean Architecture principles with composite parser pattern for routing between aviation and weather messages. ## Features Added - Weather report parsing (METAR, SPECI, TAF) - Composite parser pattern for message routing - Lenient parsing with warnings for unrecognized tokens - Support for PROB and RMK sections in TAF - Rich domain modeling with typed weather elements ## Architecture **Domain Layer** (internal/domain/weather/): - WeatherMessage interface with Metar and Taf implementations - Weather elements: Wind, Visibility, Cloud, Temperature, Altimeter, Phenomenon - Domain errors: ErrInvalidFormat, ErrMissingStation, ErrMissingTime **Port Layer** (internal/port/weather_parser.go): - WeatherParser interface with CanParse and Parse methods **Adapter Layer** (internal/adapter/parser/weather/): - WeatherParserImpl with classification and parsing logic - Comprehensive regex patterns for weather elements - METAR/SPECI parser with element extraction - TAF parser with period handling (FM, TEMPO, BECMG, PROB) - Helper functions for time parsing and unit conversions **Composite Parser** (internal/adapter/parser/composite.go): - Routes weather reports to weather parser - Falls back to aviation parser for telegrams - Converts WeatherMessage to ParsedTelegram format ## Integration - Updated ProvideParser to create composite parser with weather parser - Added weather parser to Wire DI configuration - Updated processor_bench_test.go for weather parser integration - Documentation added in docs/weather-parser.md ## Testing - 29 comprehensive tests for weather parsing (all passing) - Tests for classification, METAR, SPECI, TAF, and composite routing - Benchmark compatibility maintained ## Fixes Applied - TAF PROB parsing: Include PROB/RMK in special section detection - Composite test: Updated to use properly formatted AFTN telegram - Linter issues: Switch statement refactor, removed unused patterns - Ineffective break statement fixed in TAF parser ## Coverage ~1,743 lines of new code with: - Complete METAR/SPECI parsing - TAF parsing with period support - Lenient error handling with warnings - Unit conversions and time utilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
50 lines
1.1 KiB
Go
50 lines
1.1 KiB
Go
package weather
|
|
|
|
import (
|
|
"caatsm/internal/domain/weather"
|
|
"caatsm/internal/port"
|
|
"fmt"
|
|
)
|
|
|
|
// WeatherParserImpl implements the WeatherParser interface
|
|
type WeatherParserImpl struct{}
|
|
|
|
// NewWeatherParser creates a new weather parser instance
|
|
func NewWeatherParser() port.WeatherParser {
|
|
return &WeatherParserImpl{}
|
|
}
|
|
|
|
// CanParse determines if the raw string can be parsed as a weather report
|
|
func (p *WeatherParserImpl) CanParse(raw string) bool {
|
|
reportType, ok := Classify(raw)
|
|
if !ok {
|
|
return false
|
|
}
|
|
|
|
// Check for valid ending
|
|
if !HasValidEnding(raw) {
|
|
return false
|
|
}
|
|
|
|
_ = reportType // Suppress unused variable warning
|
|
return true
|
|
}
|
|
|
|
// Parse parses a raw weather report string and returns a WeatherMessage
|
|
func (p *WeatherParserImpl) Parse(raw string) (weather.WeatherMessage, error) {
|
|
reportType, ok := Classify(raw)
|
|
if !ok {
|
|
return nil, weather.ErrInvalidFormat
|
|
}
|
|
|
|
switch reportType {
|
|
case "METAR", "SPECI":
|
|
return parseMetar(raw, reportType)
|
|
case "TAF":
|
|
return parseTaf(raw)
|
|
default:
|
|
return nil, fmt.Errorf("unsupported report type: %s", reportType)
|
|
}
|
|
}
|
|
|