windyboyandClaude Sonnet 4.5
d0fd461e38
Implement comprehensive weather parsing capabilities following Clean Architecture principles with composite parser pattern for routing between aviation and weather messages. ## Features Added - Weather report parsing (METAR, SPECI, TAF) - Composite parser pattern for message routing - Lenient parsing with warnings for unrecognized tokens - Support for PROB and RMK sections in TAF - Rich domain modeling with typed weather elements ## Architecture **Domain Layer** (internal/domain/weather/): - WeatherMessage interface with Metar and Taf implementations - Weather elements: Wind, Visibility, Cloud, Temperature, Altimeter, Phenomenon - Domain errors: ErrInvalidFormat, ErrMissingStation, ErrMissingTime **Port Layer** (internal/port/weather_parser.go): - WeatherParser interface with CanParse and Parse methods **Adapter Layer** (internal/adapter/parser/weather/): - WeatherParserImpl with classification and parsing logic - Comprehensive regex patterns for weather elements - METAR/SPECI parser with element extraction - TAF parser with period handling (FM, TEMPO, BECMG, PROB) - Helper functions for time parsing and unit conversions **Composite Parser** (internal/adapter/parser/composite.go): - Routes weather reports to weather parser - Falls back to aviation parser for telegrams - Converts WeatherMessage to ParsedTelegram format ## Integration - Updated ProvideParser to create composite parser with weather parser - Added weather parser to Wire DI configuration - Updated processor_bench_test.go for weather parser integration - Documentation added in docs/weather-parser.md ## Testing - 29 comprehensive tests for weather parsing (all passing) - Tests for classification, METAR, SPECI, TAF, and composite routing - Benchmark compatibility maintained ## Fixes Applied - TAF PROB parsing: Include PROB/RMK in special section detection - Composite test: Updated to use properly formatted AFTN telegram - Linter issues: Switch statement refactor, removed unused patterns - Ineffective break statement fixed in TAF parser ## Coverage ~1,743 lines of new code with: - Complete METAR/SPECI parsing - TAF parsing with period support - Lenient error handling with warnings - Unit conversions and time utilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
81 lines
2.3 KiB
Go
81 lines
2.3 KiB
Go
package parser
|
|
|
|
import (
|
|
"caatsm/internal/adapter/dto"
|
|
weatherparser "caatsm/internal/adapter/parser/weather"
|
|
"caatsm/internal/port"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("CompositeParser", func() {
|
|
var composite *CompositeParser
|
|
var aviationParser Parser
|
|
var weatherParser port.WeatherParser
|
|
|
|
BeforeEach(func() {
|
|
aviationParser = &AviationParser{}
|
|
weatherParser = weatherparser.NewWeatherParser()
|
|
composite = NewCompositeParser(aviationParser, weatherParser)
|
|
})
|
|
|
|
Describe("Parse", func() {
|
|
It("should route METAR to weather parser", func() {
|
|
raw := "METAR KJFK 251200Z 35012KT 10SM FEW020 25/18 Q1013="
|
|
parsed, err := composite.Parse(raw)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(parsed).ToNot(BeNil())
|
|
Expect(parsed.Category).To(Equal("METAR"))
|
|
Expect(parsed.Parsed).To(BeTrue())
|
|
Expect(parsed.Status).To(Equal(dto.MessageStatusParsed))
|
|
})
|
|
|
|
It("should route SPECI to weather parser", func() {
|
|
raw := "SPECI KORD 251215Z 27015G25KT 5SM -RA BKN030 OVC050 20/18 A2992="
|
|
parsed, err := composite.Parse(raw)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(parsed).ToNot(BeNil())
|
|
Expect(parsed.Category).To(Equal("SPECI"))
|
|
Expect(parsed.Parsed).To(BeTrue())
|
|
})
|
|
|
|
It("should route TAF to weather parser", func() {
|
|
raw := "TAF KJFK 251200Z 2512/2612 35012KT 10SM FEW020="
|
|
parsed, err := composite.Parse(raw)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(parsed).ToNot(BeNil())
|
|
Expect(parsed.Category).To(Equal("TAF"))
|
|
Expect(parsed.Parsed).To(BeTrue())
|
|
})
|
|
|
|
It("should route aviation messages to aviation parser", func() {
|
|
raw := `ZCZC TMQ2617 142150
|
|
GG ZBTJZPZX
|
|
150551 ZBTJUOBK
|
|
(FPL-OKA2861-IS
|
|
-MA60/M-SHID/C
|
|
-ZBTJ0030
|
|
-K0420S0450 CG J1 FZ
|
|
-ZSYT0100 ZSQD ZYTL
|
|
-DOF/241215 EET/ZPKM0012 REG/B00FA PER/C)
|
|
NNNN`
|
|
parsed, err := composite.Parse(raw)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(parsed).ToNot(BeNil())
|
|
Expect(parsed.Category).To(Equal("FPL"))
|
|
Expect(parsed.Parsed).To(BeTrue())
|
|
})
|
|
|
|
It("should handle weather reports without ending =", func() {
|
|
raw := "METAR KJFK 251200Z 35012KT 10SM FEW020 25/18 Q1013"
|
|
// Should fall back to aviation parser
|
|
parsed, err := composite.Parse(raw)
|
|
// May fail or succeed depending on aviation parser
|
|
_ = parsed
|
|
_ = err
|
|
})
|
|
})
|
|
})
|
|
|