✨ Add weather report parsing for METAR, SPECI, and TAF
Implement comprehensive weather parsing capabilities following Clean Architecture principles with composite parser pattern for routing between aviation and weather messages. ## Features Added - Weather report parsing (METAR, SPECI, TAF) - Composite parser pattern for message routing - Lenient parsing with warnings for unrecognized tokens - Support for PROB and RMK sections in TAF - Rich domain modeling with typed weather elements ## Architecture **Domain Layer** (internal/domain/weather/): - WeatherMessage interface with Metar and Taf implementations - Weather elements: Wind, Visibility, Cloud, Temperature, Altimeter, Phenomenon - Domain errors: ErrInvalidFormat, ErrMissingStation, ErrMissingTime **Port Layer** (internal/port/weather_parser.go): - WeatherParser interface with CanParse and Parse methods **Adapter Layer** (internal/adapter/parser/weather/): - WeatherParserImpl with classification and parsing logic - Comprehensive regex patterns for weather elements - METAR/SPECI parser with element extraction - TAF parser with period handling (FM, TEMPO, BECMG, PROB) - Helper functions for time parsing and unit conversions **Composite Parser** (internal/adapter/parser/composite.go): - Routes weather reports to weather parser - Falls back to aviation parser for telegrams - Converts WeatherMessage to ParsedTelegram format ## Integration - Updated ProvideParser to create composite parser with weather parser - Added weather parser to Wire DI configuration - Updated processor_bench_test.go for weather parser integration - Documentation added in docs/weather-parser.md ## Testing - 29 comprehensive tests for weather parsing (all passing) - Tests for classification, METAR, SPECI, TAF, and composite routing - Benchmark compatibility maintained ## Fixes Applied - TAF PROB parsing: Include PROB/RMK in special section detection - Composite test: Updated to use properly formatted AFTN telegram - Linter issues: Switch statement refactor, removed unused patterns - Ineffective break statement fixed in TAF parser ## Coverage ~1,743 lines of new code with: - Complete METAR/SPECI parsing - TAF parsing with period support - Lenient error handling with warnings - Unit conversions and time utilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 4.5
parent
c1808c0523
commit
d0fd461e38
@@ -3,6 +3,7 @@ package app
|
||||
import (
|
||||
"caatsm/internal/adapter/dto"
|
||||
"caatsm/internal/adapter/parser"
|
||||
"caatsm/internal/adapter/parser/weather"
|
||||
"caatsm/internal/infra/config"
|
||||
"caatsm/internal/infra/telemetry"
|
||||
"context"
|
||||
@@ -61,7 +62,8 @@ NNNN`)
|
||||
|
||||
// createBenchmarkProcessor creates a processor with mocks for benchmarking
|
||||
func createBenchmarkProcessor() *MessageProcessor {
|
||||
aviationParser := parser.ProvideParser()
|
||||
weatherParser := weather.NewWeatherParser()
|
||||
aviationParser := parser.ProvideParser(weatherParser)
|
||||
mockRepo := &mockRepository{}
|
||||
mockPub := &mockPublisher{}
|
||||
logger := zap.NewNop()
|
||||
@@ -135,7 +137,8 @@ func BenchmarkHandleMixed(b *testing.B) {
|
||||
// BenchmarkHandleParseOnly benchmarks parsing without persistence/publishing
|
||||
// This isolates parser performance
|
||||
func BenchmarkHandleParseOnly(b *testing.B) {
|
||||
aviationParser := parser.ProvideParser()
|
||||
weatherParser := weather.NewWeatherParser()
|
||||
aviationParser := parser.ProvideParser(weatherParser)
|
||||
// Use a repository that does nothing
|
||||
mockRepo := &mockRepository{}
|
||||
// Use a publisher that does nothing
|
||||
|
||||
Reference in New Issue
Block a user