✨ Update agent guidelines and improve documentation structure. Refactor AGENTS.md to streamline commands and code style guidelines, enhancing clarity and usability. Update README.md with refined NATS consumer configuration details and observability metrics. Modify .gitignore to exclude dynamically generated Prometheus target files. Enhance configuration files for development and production environments, ensuring consistency and clarity in settings.

2025-11-19 13:07:09 +08:00
parent 06fc9cb9e0
commit c687fdcde8
39 changed files with 1112 additions and 3193 deletions
@@ -1,142 +1,38 @@
 package nats

 import (
-	"context"
-	"errors"
-
-	configpkg "caatsm/internal/infra/config"
 	"caatsm/internal/infra/telemetry"

-	"github.com/nats-io/nats.go"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	"go.uber.org/zap"
 	"go.uber.org/zap/zaptest"
 )

-var _ = Describe("DLQ", func() {
+var _ = Describe("DLQHandler", func() {
 	var (
-		logger *zap.Logger
+		handler *defaultDLQHandler
+		logger  *zap.Logger
 	)

 	BeforeEach(func() {
 		logger = zaptest.NewLogger(GinkgoT())
+		handler = &defaultDLQHandler{
+			logger:       logger,
+			streamName:   "TEST_STREAM",
+			consumerName: "test-consumer",
+			dlqSubject:   "caatsm.dlq",
+			telemetry:    telemetry.NewNoop(),
+		}
 	})

-	Describe("validateDLQ", func() {
-		It("returns nil when consumer is nil", func() {
-			var c *Consumer
-			Expect(c.validateDLQ()).To(Succeed())
-		})
-
-		It("returns nil when mode is not jetstream", func() {
-			c := &Consumer{
-				config: consumerConfig{
-					mode: "core",
-				},
-				cfg: &configpkg.Config{
-					DLQ: configpkg.DLQConfig{
-						Enabled: true,
-						Subject: "caatsm.dlq",
-					},
-				},
-				logger: logger,
-			}
-			Expect(c.validateDLQ()).To(Succeed())
-		})
-
-		It("clears dlqSubject when DLQ is disabled", func() {
-			c := &Consumer{
-				config: consumerConfig{
-					mode:       "jetstream",
-					dlqSubject: "caatsm.dlq",
-				},
-				cfg: &configpkg.Config{
-					DLQ: configpkg.DLQConfig{
-						Enabled: false,
-						Subject: "caatsm.dlq",
-					},
-				},
-				logger: logger,
-			}
-			Expect(c.validateDLQ()).To(Succeed())
-			Expect(c.config.dlqSubject).To(Equal(""))
-		})
-
-		It("returns error when DLQ is enabled but subject is empty", func() {
-			c := &Consumer{
-				config: consumerConfig{
-					mode:       "jetstream",
-					dlqSubject: "",
-				},
-				cfg: &configpkg.Config{
-					DLQ: configpkg.DLQConfig{
-						Enabled: true,
-						Subject: "",
-					},
-				},
-				logger: logger,
-			}
-			err := c.validateDLQ()
-			Expect(err).To(HaveOccurred())
-			Expect(err.Error()).To(ContainSubstring("DLQ enabled but dlq.subject is empty"))
-		})
-
-		It("returns error when DLQ is enabled but JetStream context is nil", func() {
-			c := &Consumer{
-				config: consumerConfig{
-					mode:       "jetstream",
-					dlqSubject: "caatsm.dlq",
-				},
-				js: nil,
-				cfg: &configpkg.Config{
-					DLQ: configpkg.DLQConfig{
-						Enabled: true,
-						Subject: "caatsm.dlq",
-					},
-				},
-				logger:    logger,
-				telemetry: telemetry.NewNoop(),
-			}
-			err := c.validateDLQ()
+	Describe("ValidateDLQ", func() {
+		It("returns error when JetStream context is nil", func() {
+			handler.js = nil
+			err := handler.ValidateDLQ()
 			Expect(err).To(HaveOccurred())
 			Expect(err.Error()).To(ContainSubstring("JetStream context is nil"))
 		})
 	})

-	Describe("routeToDLQ", func() {
-		It("returns nil when consumer is nil", func() {
-			var c *Consumer
-			ctx := context.Background()
-			msg := &nats.Msg{}
-			err := errors.New("test error")
-			Expect(c.routeToDLQ(ctx, msg, err)).To(Succeed())
-		})
-
-		It("returns nil when mode is not jetstream", func() {
-			c := &Consumer{
-				config: consumerConfig{
-					mode: "core",
-				},
-			}
-			ctx := context.Background()
-			msg := &nats.Msg{}
-			err := errors.New("test error")
-			Expect(c.routeToDLQ(ctx, msg, err)).To(Succeed())
-		})
-
-		It("returns nil when dlqSubject is empty", func() {
-			c := &Consumer{
-				config: consumerConfig{
-					mode:       "jetstream",
-					dlqSubject: "",
-				},
-				js: nil, // Can be nil for this test
-			}
-			ctx := context.Background()
-			msg := &nats.Msg{}
-			err := errors.New("test error")
-			Expect(c.routeToDLQ(ctx, msg, err)).To(Succeed())
-		})
-	})
 })