✨ Enhance aviation parser with security fixes and comprehensive refactoring

This commit implements a complete refactoring of the ICAO aviation parser, addressing 15 identified issues across security, performance, code quality, and documentation. Security Enhancements (P0 - Critical): - Add input size validation (max 1800 chars per AFTN standard) - Implement ReDoS protection with 100ms regex timeout mechanism - Add field validation to prevent nil pointer dereferences - Document intentional error handling pattern for audit compliance Performance & Design Improvements (P1 - Important): - Remove unnecessary mutex from BodyParser (eliminates serialization) - Fix tokenizer slash handling logic - Remove global logger dependencies (zap.S() calls) Code Quality Improvements (P2): - Refactor parseRemainingLines with clear helper functions - Document all regex patterns with ICAO format specifications - Replace magic numbers with named constants (5 new constants) - Add error message sanitization to prevent data leakage Documentation & Polish (P3): - Create comprehensive package documentation (doc.go) - Verify naming consistency across all functions - Add 54 comprehensive tests (all passing) - Verify performance with benchmarks (~10µs for simple messages) New Files: - validation.go: Input validation utilities with AFTN limits - validation_test.go: Comprehensive validation tests - regex_timeout.go: ReDoS protection mechanism - regex_timeout_test.go: Timeout protection tests - suite_test.go: Ginkgo test suite registration - doc.go: Package-level documentation All changes maintain backward compatibility and existing architecture while significantly enhancing security, maintainability, and code quality. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-26 17:55:25 +08:00
parent ba82b9206a
commit c0a66cf845
12 changed files with 1075 additions and 127 deletions
@@ -33,13 +33,35 @@ func (arrParser) Patterns() []PatternConfig {
 }

 func (arrParser) Parse(_ ParseContext, data map[string]string) (interface{}, error) {
+	// Validate and extract required fields
+	category, err := GetRequiredField(data, Category)
+	if err != nil {
+		return nil, err
+	}
+	aircraftID, err := GetRequiredField(data, FlightNumber)
+	if err != nil {
+		return nil, err
+	}
+	depAirport, err := GetRequiredField(data, DepartureCode)
+	if err != nil {
+		return nil, err
+	}
+	arrAirport, err := GetRequiredField(data, ArrivalCode)
+	if err != nil {
+		return nil, err
+	}
+	arrTime, err := GetRequiredField(data, ArrivalTime)
+	if err != nil {
+		return nil, err
+	}
+
 	return &domain.ARR{
-		Category:         data[Category],
-		AircraftID:       data[FlightNumber],
-		SSRModeAndCode:   data[SSR],
-		DepartureAirport: data[DepartureCode],
-		ArrivalAirport:   data[ArrivalCode],
-		ArrivalTime:      data[ArrivalTime],
+		Category:         category,
+		AircraftID:       aircraftID,
+		SSRModeAndCode:   GetOptionalField(data, SSR),
+		DepartureAirport: depAirport,
+		ArrivalAirport:   arrAirport,
+		ArrivalTime:      arrTime,
 	}, nil
 }

@@ -58,13 +80,35 @@ func (depParser) Patterns() []PatternConfig {
 }

 func (depParser) Parse(_ ParseContext, data map[string]string) (interface{}, error) {
+	// Validate and extract required fields
+	category, err := GetRequiredField(data, Category)
+	if err != nil {
+		return nil, err
+	}
+	aircraftID, err := GetRequiredField(data, FlightNumber)
+	if err != nil {
+		return nil, err
+	}
+	depAirport, err := GetRequiredField(data, DepartureCode)
+	if err != nil {
+		return nil, err
+	}
+	depTime, err := GetRequiredField(data, DepartureTime)
+	if err != nil {
+		return nil, err
+	}
+	destination, err := GetRequiredField(data, ArrivalCode)
+	if err != nil {
+		return nil, err
+	}
+
 	return &domain.DEP{
-		Category:         data[Category],
-		AircraftID:       data[FlightNumber],
-		SSRModeAndCode:   data[SSR],
-		DepartureAirport: data[DepartureCode],
-		DepartureTime:    data[DepartureTime],
-		Destination:      data[ArrivalCode],
+		Category:         category,
+		AircraftID:       aircraftID,
+		SSRModeAndCode:   GetOptionalField(data, SSR),
+		DepartureAirport: depAirport,
+		DepartureTime:    depTime,
+		Destination:      destination,
 	}, nil
 }

@@ -83,11 +127,29 @@ func (cnlParser) Patterns() []PatternConfig {
 }

 func (cnlParser) Parse(_ ParseContext, data map[string]string) (interface{}, error) {
+	// Validate and extract required fields
+	category, err := GetRequiredField(data, Category)
+	if err != nil {
+		return nil, err
+	}
+	aircraftID, err := GetRequiredField(data, FlightNumber)
+	if err != nil {
+		return nil, err
+	}
+	depAirport, err := GetRequiredField(data, DepartureCode)
+	if err != nil {
+		return nil, err
+	}
+	destAirport, err := GetRequiredField(data, ArrivalCode)
+	if err != nil {
+		return nil, err
+	}
+
 	return &domain.CNL{
-		Category:           data[Category],
-		AircraftID:         data[FlightNumber],
-		DepartureAirport:   data[DepartureCode],
-		DestinationAirport: data[ArrivalCode],
+		Category:           category,
+		AircraftID:         aircraftID,
+		DepartureAirport:   depAirport,
+		DestinationAirport: destAirport,
 	}, nil
 }

@@ -106,13 +168,31 @@ func (dlaParser) Patterns() []PatternConfig {
 }

 func (dlaParser) Parse(_ ParseContext, data map[string]string) (interface{}, error) {
+	// Validate and extract required fields
+	category, err := GetRequiredField(data, Category)
+	if err != nil {
+		return nil, err
+	}
+	aircraftID, err := GetRequiredField(data, FlightNumber)
+	if err != nil {
+		return nil, err
+	}
+	depAirport, err := GetRequiredField(data, DepartureCode)
+	if err != nil {
+		return nil, err
+	}
+	arrAirport, err := GetRequiredField(data, ArrivalCode)
+	if err != nil {
+		return nil, err
+	}
+
 	return &domain.DLA{
-		Category:         data[Category],
-		AircraftID:       data[FlightNumber],
-		DepartureAirport: data[DepartureCode],
-		NewDepartureTime: data[DepartureTime],
-		ArrivalAirport:   data[ArrivalCode],
-		ArrivalTime:      data[ArrivalTime],
+		Category:         category,
+		AircraftID:       aircraftID,
+		DepartureAirport: depAirport,
+		NewDepartureTime: GetOptionalField(data, DepartureTime),
+		ArrivalAirport:   arrAirport,
+		ArrivalTime:      GetOptionalField(data, ArrivalTime),
 	}, nil
 }

@@ -131,23 +211,72 @@ func (fplParser) Patterns() []PatternConfig {
 }

 func (fplParser) Parse(_ ParseContext, data map[string]string) (interface{}, error) {
-	otherData := parseOther(data[OtherInfo])
+	// Validate and extract required fields
+	category, err := GetRequiredField(data, Category)
+	if err != nil {
+		return nil, err
+	}
+	flightNumber, err := GetRequiredField(data, FlightNumber)
+	if err != nil {
+		return nil, err
+	}
+	aircraftID, err := GetRequiredField(data, AircraftID)
+	if err != nil {
+		return nil, err
+	}
+	indicator, err := GetRequiredField(data, Indicator)
+	if err != nil {
+		return nil, err
+	}
+	speed, err := GetRequiredField(data, Speed)
+	if err != nil {
+		return nil, err
+	}
+	level, err := GetRequiredField(data, Level)
+	if err != nil {
+		return nil, err
+	}
+	depAirport, err := GetRequiredField(data, DepartureCode)
+	if err != nil {
+		return nil, err
+	}
+	depTime, err := GetRequiredField(data, DepartureTime)
+	if err != nil {
+		return nil, err
+	}
+	route, err := GetRequiredField(data, Route)
+	if err != nil {
+		return nil, err
+	}
+	destCode, err := GetRequiredField(data, DestinationCode)
+	if err != nil {
+		return nil, err
+	}
+	estTime, err := GetRequiredField(data, EstimatedTime)
+	if err != nil {
+		return nil, err
+	}
+
+	// Parse optional "other" fields
+	otherInfo := GetOptionalField(data, OtherInfo)
+	otherData := parseOther(otherInfo)
+
 	return &domain.FPL{
-		Category:                data[Category],
-		FlightNumber:            data[FlightNumber],
-		ReferenceData:           data[ReferenceData],
-		AircraftID:              data[AircraftID],
-		SSRModeAndCode:          data[Surveillance],
-		FlightRulesAndType:      data[Indicator],
-		CruisingSpeedAndLevel:   data[Speed] + data[Level],
-		DepartureAirport:        data[DepartureCode],
-		DepartureTime:           data[DepartureTime],
-		Route:                   data[Route],
-		DestinationAndTotalTime: data[DestinationCode] + data[EstimatedTime],
-		AlternateAirport:        data[AlternateAirport],
-		OtherInfo:               data[OtherInfo],
+		Category:                category,
+		FlightNumber:            flightNumber,
+		ReferenceData:           GetOptionalField(data, ReferenceData),
+		AircraftID:              aircraftID,
+		SSRModeAndCode:          GetOptionalField(data, Surveillance),
+		FlightRulesAndType:      indicator,
+		CruisingSpeedAndLevel:   speed + level,
+		DepartureAirport:        depAirport,
+		DepartureTime:           depTime,
+		Route:                   route,
+		DestinationAndTotalTime: destCode + estTime,
+		AlternateAirport:        GetOptionalField(data, AlternateAirport),
+		OtherInfo:               otherInfo,
 		Register:                otherData[Register],
-		EstimatedArrivalTime:    data[EstimatedTime],
+		EstimatedArrivalTime:    estTime,
 		PBN:                     otherData[PBN],
 		NavigationEquipment:     otherData[NavigationEquipment],
 		EstimatedElapsedTime:    otherData[EstimatedElapsedTime],