improve review-plan preview output and docs
This commit is contained in:
windyboy
+184
-38
@@ -24,61 +24,86 @@ def _write_config(path: Path, library_root: Path) -> None:
|
||||
'quarantine_dir: ".quarantine"',
|
||||
'log_level: "INFO"',
|
||||
]
|
||||
)
|
||||
),
|
||||
encoding="utf-8",
|
||||
)
|
||||
|
||||
|
||||
def test_review_plan_generates_csv_and_summary(tmp_path):
|
||||
"""review-plan should export flagged operations and summary counters."""
|
||||
def _write_plan(path: Path, operations: list[dict], summary: dict, human_summary: str = "") -> None:
|
||||
plan_data = {
|
||||
"vlm_schema_version": "1.0",
|
||||
"plan_id": "test-plan",
|
||||
"created_at": "2026-02-13T00:00:00+00:00",
|
||||
"operations": operations,
|
||||
"summary": summary,
|
||||
"summary_by_reason": {},
|
||||
"human_summary": human_summary,
|
||||
"metadata": {},
|
||||
}
|
||||
path.write_text(json.dumps(plan_data), encoding="utf-8")
|
||||
|
||||
|
||||
def _invoke_review_plan(runner: CliRunner, config_path: Path, args: list[str]):
|
||||
return runner.invoke(main, ["--config", str(config_path), "review-plan", *args])
|
||||
|
||||
|
||||
def test_review_plan_generates_csv_summary_and_preview(tmp_path):
|
||||
"""review-plan should export CSV, show summary, and print preview content."""
|
||||
config_path = tmp_path / "config.yaml"
|
||||
_write_config(config_path, tmp_path / "library")
|
||||
|
||||
plan_path = tmp_path / "plan.json"
|
||||
plan_data = {
|
||||
"plan_id": "test-plan",
|
||||
"created_at": "2026-02-13T00:00:00+00:00",
|
||||
"operations": [
|
||||
{
|
||||
"operation_type": "move",
|
||||
"source_path": str(tmp_path / "Show.Sample.S01E01.mkv"),
|
||||
"destination_path": str(tmp_path / "library/series/Show/Season 01/S01E01.mkv"),
|
||||
"reason": "Organize series: Show S01E01",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Show.S20E50.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
],
|
||||
"summary": {"total": 2, "move": 1, "rename": 0, "quarantine": 0, "no-op": 1},
|
||||
"summary_by_reason": {},
|
||||
"human_summary": "",
|
||||
"metadata": {},
|
||||
}
|
||||
plan_path.write_text(json.dumps(plan_data), encoding="utf-8")
|
||||
operations = [
|
||||
{
|
||||
"operation_type": "move",
|
||||
"source_path": str(tmp_path / "Show.Sample.S01E01.mkv"),
|
||||
"destination_path": str(tmp_path / "library/series/Show/Season 01/S01E01.mkv"),
|
||||
"reason": "Organize series: Show S01E01",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Show.S20E50.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
]
|
||||
_write_plan(
|
||||
plan_path,
|
||||
operations=operations,
|
||||
summary={"total": 2, "move": 1, "rename": 0, "quarantine": 0, "no-op": 1},
|
||||
human_summary="这是测试计划摘要",
|
||||
)
|
||||
|
||||
output_csv = tmp_path / "review.csv"
|
||||
runner = CliRunner()
|
||||
result = runner.invoke(
|
||||
main,
|
||||
result = _invoke_review_plan(
|
||||
runner,
|
||||
config_path,
|
||||
[
|
||||
"--config", str(config_path),
|
||||
"review-plan",
|
||||
"--input", str(plan_path),
|
||||
"--output", str(output_csv),
|
||||
"--season-threshold", "20",
|
||||
"--episode-threshold", "40",
|
||||
"--input",
|
||||
str(plan_path),
|
||||
"--output",
|
||||
str(output_csv),
|
||||
"--season-threshold",
|
||||
"20",
|
||||
"--episode-threshold",
|
||||
"40",
|
||||
],
|
||||
)
|
||||
|
||||
assert result.exit_code == 0
|
||||
assert "Plan overview:" in result.output
|
||||
assert "这是测试计划摘要" in result.output
|
||||
assert "Plan review summary:" in result.output
|
||||
assert "High-risk operations: 2" in result.output
|
||||
assert "High-risk operations preview:" in result.output
|
||||
assert "source:" in result.output
|
||||
assert "destination:" in result.output
|
||||
assert "reason:" in result.output
|
||||
assert output_csv.exists()
|
||||
|
||||
with open(output_csv, "r", encoding="utf-8", newline="") as f:
|
||||
@@ -86,3 +111,124 @@ def test_review_plan_generates_csv_and_summary(tmp_path):
|
||||
assert len(rows) == 2
|
||||
assert any("sample_source" in row["risk_flags"] for row in rows)
|
||||
assert any("manual_review" in row["risk_flags"] for row in rows)
|
||||
|
||||
|
||||
def test_review_plan_preview_limit_controls_console_output(tmp_path):
|
||||
"""--preview-limit should cap displayed high-risk operations and report remaining count."""
|
||||
config_path = tmp_path / "config.yaml"
|
||||
_write_config(config_path, tmp_path / "library")
|
||||
|
||||
plan_path = tmp_path / "plan.json"
|
||||
operations = [
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Series.S20E41.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Series.S20E42.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Series.S20E43.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
]
|
||||
_write_plan(
|
||||
plan_path,
|
||||
operations=operations,
|
||||
summary={"total": 3, "move": 0, "rename": 0, "quarantine": 0, "no-op": 3},
|
||||
)
|
||||
|
||||
output_csv = tmp_path / "review.csv"
|
||||
runner = CliRunner()
|
||||
result = _invoke_review_plan(
|
||||
runner,
|
||||
config_path,
|
||||
[
|
||||
"--input",
|
||||
str(plan_path),
|
||||
"--output",
|
||||
str(output_csv),
|
||||
"--preview-limit",
|
||||
"1",
|
||||
],
|
||||
)
|
||||
|
||||
assert result.exit_code == 0
|
||||
assert " - [1] " in result.output
|
||||
assert " - [2] " not in result.output
|
||||
assert " - [3] " not in result.output
|
||||
assert "... and 2 more high-risk operations" in result.output
|
||||
|
||||
|
||||
def test_review_plan_show_all_overrides_preview_limit(tmp_path):
|
||||
"""--show-all should display all high-risk operations regardless of --preview-limit."""
|
||||
config_path = tmp_path / "config.yaml"
|
||||
_write_config(config_path, tmp_path / "library")
|
||||
|
||||
plan_path = tmp_path / "plan.json"
|
||||
operations = [
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Series.S20E51.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Series.S20E52.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
{
|
||||
"operation_type": "no-op",
|
||||
"source_path": str(tmp_path / "Series.S20E53.mkv"),
|
||||
"destination_path": None,
|
||||
"reason": "Series needs manual review (season exceeds configured threshold)",
|
||||
"has_conflict": False,
|
||||
"conflict_reason": None,
|
||||
},
|
||||
]
|
||||
_write_plan(
|
||||
plan_path,
|
||||
operations=operations,
|
||||
summary={"total": 3, "move": 0, "rename": 0, "quarantine": 0, "no-op": 3},
|
||||
)
|
||||
|
||||
output_csv = tmp_path / "review.csv"
|
||||
runner = CliRunner()
|
||||
result = _invoke_review_plan(
|
||||
runner,
|
||||
config_path,
|
||||
[
|
||||
"--input",
|
||||
str(plan_path),
|
||||
"--output",
|
||||
str(output_csv),
|
||||
"--preview-limit",
|
||||
"1",
|
||||
"--show-all",
|
||||
],
|
||||
)
|
||||
|
||||
assert result.exit_code == 0
|
||||
assert " - [1] " in result.output
|
||||
assert " - [2] " in result.output
|
||||
assert " - [3] " in result.output
|
||||
assert "more high-risk operations" not in result.output
|
||||
|
||||
Reference in New Issue
Block a user